Fix disaggregation #674
Merged
Fix disaggregation #674
+117
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosEpia
requested changes
Oct 18, 2023
This es especially needed when all generators are PQ-controlled (e.g. load shedding) and there is no reactive power time series that needs to be distributed
This happens within the pf_post_lopf anyhow. But before, the change was only done for the aggregated and not the disaggregated network which resulted into problems when disaggregating
CarlosEpia
approved these changes
Oct 19, 2023
|
The problems when disaggregating load_shedding generators after the pf_post_lopf occur because the control strategies for generators are set multiple times, and sometimes different. |
The control parameters are overwitten within pypsa's network clustering, because slack generators are selected. In order to not keep this change, the function set_contro_strategies needs to be called again after every spatial clustering.
I fixed the problems, it now also works when the pf was executed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR to disaggregate links and stores (#629) included some problems, e.g. 95c22f0 assumed that
etrago.clustering.busmapis apandas.Series, but it is a dictionary.In addition, some commits from https://github.com/openego/eTraGo/tree/features/disaggregate-links-and-stores-update-busmap were not part of the merged branch.
I fixed those problems in this branch.
This branch also solves #644